Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL VSCode warning: Multischema type checking doesn't seem to work #271

Closed
3 tasks done
nathanchapman opened this issue Apr 26, 2024 · 4 comments
Closed
3 tasks done
Labels
editor support ✍️ An issue related to a specific editor, extension, editor or IDE, external from gql.tada won't fix 🛑 This issue won't be fixed as part of the current roadmap

Comments

@nathanchapman
Copy link

Describe the bug

Added an unexpected field to the query, which reflects in VS Code
image

but type checking passed unexpectedly
image

Reproduction

No response

gql.tada version

1.6.1

Validations

  • I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
  • Read the docs.
  • Follow our Code of Conduct
@kitten
Copy link
Member

kitten commented Apr 26, 2024

We'll need a reproduction here, without more information there's nothing I can do, sorry

@kitten kitten added the needs more info ✋ A question or report that needs more info to be addressable label Apr 26, 2024
@nathanchapman
Copy link
Author

@kitten will get one added shortly

@kitten
Copy link
Member

kitten commented Apr 26, 2024

Actually, I think I can see what's going on.
The dialog here says "GraphQL: Validation".

This is not a warning from GraphQLSP, but from the GraphiQL/"GraphQL Language Feature Support" extension (i.e. https://marketplace.visualstudio.com/items?itemName=GraphQL.vscode-graphql)

This has been a bit problematic. It doesn't seem like we can alter or suggest changes to the in-repo .vscode/settings.json to prevent these errors but the gql.tada doctor command should point out to you that you have the extension installed and that it's an issue.

@kitten kitten added won't fix 🛑 This issue won't be fixed as part of the current roadmap and removed needs more info ✋ A question or report that needs more info to be addressable labels Apr 26, 2024
@kitten kitten changed the title Multischema type checking doesn't seem to work GraphiQL VSCode warning: Multischema type checking doesn't seem to work Apr 26, 2024
@kitten
Copy link
Member

kitten commented Apr 26, 2024

Duplicate of #194

Edit: There's a reference to a fix in that extension here: graphql/graphiql#3588 (comment)
(Provided it's configured correctly to exclude ts(x) files handled by GraphQLSP/gql.tada

@kitten kitten marked this as a duplicate of #194 Apr 26, 2024
@kitten kitten closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
@kitten kitten added the editor support ✍️ An issue related to a specific editor, extension, editor or IDE, external from gql.tada label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor support ✍️ An issue related to a specific editor, extension, editor or IDE, external from gql.tada won't fix 🛑 This issue won't be fixed as part of the current roadmap
Projects
None yet
Development

No branches or pull requests

2 participants