Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n - Some strings aren't translatable and others need small fixes #294

Closed
1 task done
pedro-mendonca opened this issue Aug 5, 2024 · 0 comments · Fixed by #295
Closed
1 task done

i18n - Some strings aren't translatable and others need small fixes #294

pedro-mendonca opened this issue Aug 5, 2024 · 0 comments · Fixed by #295
Assignees
@pedro-mendonca
Labels
type:bug Something isn’t working.
Milestone
2.8.0

Comments

@pedro-mendonca
Copy link
Contributor

pedro-mendonca commented Aug 5, 2024 •
edited
Loading

Describe the bug

Some translation strings don't have textdomain, some have the wrong textdomain and others have no comment to translators.

Steps to Reproduce

  1. Set WP to a language that the plugin has the full translation
  2. Go to Settings > Discussion
  3. See some strings untranslated

Screenshots, screen recording, code snippet

imagem

Environment information

No response

WordPress information

WP 6.6.x

Code of Conduct

  • I agree to follow this project's Code of Conduct
@pedro-mendonca pedro-mendonca added the type:bug Something isn’t working. label Aug 5, 2024
@pedro-mendonca pedro-mendonca mentioned this issue Aug 5, 2024
Merged
8 tasks
@jeffpaul jeffpaul added this to the 2.8.0 milestone Aug 5, 2024
@jeffpaul jeffpaul moved this from Incoming to Code Review in Open Source Practice Aug 5, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Done in Open Source Practice Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedro-mendonca pedro-mendonca

Labels
type:bug Something isn’t working.
Projects
Open Source Practice
Archived in project
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

Fix i18n issues pedro-mendonca/simple-local-avatars
2 participants
@jeffpaul @pedro-mendonca