Replace set-output with Environment Files in GitHub Actions workflow

[sgibson91]

Context

On a recent CI/CD run, this warning was triggered:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

We use set-output a lot to allow for sharing of variables between steps/jobs throughout various workflows. We should update to the proposed Environment Files workflow before this feature is disabled.

Proposal

No response

Updates and actions

No response

[choldgraf]

Relevant info from the post:

We are monitoring telemetry for the usage of these commands and plan to fully disable them on 31st May 2023

And a quick highlight of how this works, since I do this in a few other projects and looked it up:

A workflow using save-state or set-output like the following

- name: Save state
  run: echo "::save-state name={name}::{value}"

- name: Set output
  run: echo "::set-output name={name}::{value}"

should be updated to write to the new GITHUB_STATE and GITHUB_OUTPUT environment files:

- name: Save state
  run: echo "{name}={value}" >> $GITHUB_STATE

- name: Set output
  run: echo "{name}={value}" >> $GITHUB_OUTPUT

[sgibson91]

This Stack Overflow answer demonstrates how we can replace the following statements in Python scripts by writing to a file: https://stackoverflow.com/a/70123641

print(f"::set-output ...")

[sgibson91]

Will be closed by:

• [CI/CD] Replace set-output with writing to GITHUB_ENV in various workflows #1865

[choldgraf]

Just want to say thanks @sgibson91 for doing this because I'll likely need to reference this PR in remembering how to do this in a few other projects too haha

[sgibson91]

We are still seeing this error message, but I think this is due to code in the Azure/setup-kubectl action we depend on in .github/actions/deploy-setup/. Upstream issue below, no further action from us other than to consume the new release of the action when it's ready (which dependabot should tell us about...?... I might check that)

• Bug: Action causes deprecated 'set-output' command warning Azure/setup-kubectl#69

[sgibson91]

Also it seems like the nick-fields/retry action is causing it too

UMMMMMM, should probs address that critical error too? 😅 Opened #1875 to track.