Skip to content

Commit

Permalink
Updating the package
Browse files Browse the repository at this point in the history
 * Allow to install laravel 6 minor releases
 * Updating the service provider
  • Loading branch information
arcanedev-maroc committed Oct 3, 2019
1 parent 78ee2c1 commit 5599323
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 49 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
* Easy setup & configuration.
* Well documented & IDE Friendly.
* Well tested with maximum code quality.
* Laravel `5.1` to `6.0` are supported.
* Laravel `5.1` to `6.x` are supported.
* Made with :heart: & :coffee:.

## Table of contents
Expand All @@ -42,7 +42,7 @@ If you discover any security related issues, please email arcanedev.maroc@gmail.
- [ARCANEDEV][link-author]
- [All Contributors][link-contributors]

[badge_laravel]: https://img.shields.io/badge/For%20Laravel-5.1%20to%206.0-orange.svg?style=flat-square
[badge_laravel]: https://img.shields.io/badge/For%20Laravel-5.1%20to%206.x-orange.svg?style=flat-square
[badge_license]: https://img.shields.io/packagist/l/arcanedev/laravel-notes.svg?style=flat-square
[badge_build]: https://img.shields.io/travis/ARCANEDEV/LaravelNotes.svg?style=flat-square
[badge_coverage]: https://img.shields.io/scrutinizer/coverage/g/ARCANEDEV/LaravelNotes.svg?style=flat-square
Expand Down
2 changes: 1 addition & 1 deletion _docs/0-Home.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This Laravel Notes will allow you to add a notes system into your Laravel projec
* Easy setup & configuration.
* Well documented & IDE Friendly.
* Well tested with maximum code quality.
* Laravel `5.1` to `6.0` are supported.
* Laravel `5.1` to `6.x` are supported.
* Made with :heart: & :coffee:.

## Table of contents
Expand Down
28 changes: 10 additions & 18 deletions _docs/1-Installation-and-Setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@
2. [Configuration](2-Configuration.md)
3. [Usage](3-Usage.md)

## Server Requirements

The Laravel Notes package has a few system requirements:

```
- PHP >= 7.1.3
```

## Version Compatibility

| Laravel Notes | Laravel |
Expand All @@ -24,7 +16,7 @@ The Laravel Notes package has a few system requirements:
| ![Laravel Notes v3.x][laravel_notes_3_x] | ![Laravel v5.6][laravel_5_6] |
| ![Laravel Notes v4.x][laravel_notes_4_x] | ![Laravel v5.7][laravel_5_7] |
| ![Laravel Notes v5.x][laravel_notes_5_x] | ![Laravel v5.8][laravel_5_8] |
| ![Laravel Notes v6.x][laravel_notes_6_x] | ![Laravel v6.0][laravel_6_0] |
| ![Laravel Notes v6.x][laravel_notes_6_x] | ![Laravel v6.x][laravel_6_x] |

[laravel_5_1]: https://img.shields.io/badge/v5.1-supported-brightgreen.svg?style=flat-square "Laravel v5.1"
[laravel_5_2]: https://img.shields.io/badge/v5.2-supported-brightgreen.svg?style=flat-square "Laravel v5.2"
Expand All @@ -34,15 +26,15 @@ The Laravel Notes package has a few system requirements:
[laravel_5_6]: https://img.shields.io/badge/v5.6-supported-brightgreen.svg?style=flat-square "Laravel v5.6"
[laravel_5_7]: https://img.shields.io/badge/v5.7-supported-brightgreen.svg?style=flat-square "Laravel v5.7"
[laravel_5_8]: https://img.shields.io/badge/v5.8-supported-brightgreen.svg?style=flat-square "Laravel v5.8"
[laravel_6_0]: https://img.shields.io/badge/v6.0-supported-brightgreen.svg?style=flat-square "Laravel v6.0"

[laravel_notes_0_x]: https://img.shields.io/badge/version-0.*-blue.svg?style=flat-square "LaravelNotes v0.*"
[laravel_notes_1_x]: https://img.shields.io/badge/version-1.*-blue.svg?style=flat-square "LaravelNotes v1.*"
[laravel_notes_2_x]: https://img.shields.io/badge/version-2.*-blue.svg?style=flat-square "LaravelNotes v2.*"
[laravel_notes_3_x]: https://img.shields.io/badge/version-3.*-blue.svg?style=flat-square "LaravelNotes v3.*"
[laravel_notes_4_x]: https://img.shields.io/badge/version-4.*-blue.svg?style=flat-square "LaravelNotes v4.*"
[laravel_notes_5_x]: https://img.shields.io/badge/version-5.*-blue.svg?style=flat-square "LaravelNotes v5.*"
[laravel_notes_6_x]: https://img.shields.io/badge/version-6.*-blue.svg?style=flat-square "LaravelNotes v6.*"
[laravel_6_x]: https://img.shields.io/badge/v6.x-supported-brightgreen.svg?style=flat-square "Laravel v6.x"

[laravel_notes_0_x]: https://img.shields.io/badge/version-0.x-blue.svg?style=flat-square "LaravelNotes v0.x"
[laravel_notes_1_x]: https://img.shields.io/badge/version-1.x-blue.svg?style=flat-square "LaravelNotes v1.x"
[laravel_notes_2_x]: https://img.shields.io/badge/version-2.x-blue.svg?style=flat-square "LaravelNotes v2.x"
[laravel_notes_3_x]: https://img.shields.io/badge/version-3.x-blue.svg?style=flat-square "LaravelNotes v3.x"
[laravel_notes_4_x]: https://img.shields.io/badge/version-4.x-blue.svg?style=flat-square "LaravelNotes v4.x"
[laravel_notes_5_x]: https://img.shields.io/badge/version-5.x-blue.svg?style=flat-square "LaravelNotes v5.x"
[laravel_notes_6_x]: https://img.shields.io/badge/version-6.x-blue.svg?style=flat-square "LaravelNotes v6.x"

## Composer

Expand Down
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
"license": "MIT",
"require": {
"php": ">=7.2.0",
"arcanedev/support": "~5.0.0"
"arcanedev/support": "^5.0"
},
"require-dev": {
"orchestra/testbench": "~4.0.0",
"mockery/mockery": "~1.0",
"phpunit/phpunit": "~8.0",
"phpunit/phpcov": "~6.0"
"orchestra/testbench": "^4.0",
"mockery/mockery": "^1.0",
"phpunit/phpunit": "^8.0",
"phpunit/phpcov": "^6.0"
},
"autoload": {
"psr-4": {
Expand Down
19 changes: 4 additions & 15 deletions src/LaravelNotesServiceProvider.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php namespace Arcanedev\LaravelNotes;

use Arcanedev\Support\PackageServiceProvider;
use Arcanedev\Support\Providers\PackageServiceProvider;

/**
* Class LaravelNotesServiceProvider
Expand Down Expand Up @@ -30,7 +30,7 @@ class LaravelNotesServiceProvider extends PackageServiceProvider
/**
* Register the service provider.
*/
public function register()
public function register(): void
{
parent::register();

Expand All @@ -40,21 +40,10 @@ public function register()
/**
* Boot the service provider.
*/
public function boot()
public function boot(): void
{
parent::boot();

$this->publishConfig();
LaravelNotes::$publishMigrations ? $this->publishMigrations() : $this->loadMigrations();
}

/**
* Get the services provided by the provider.
*
* @return array
*/
public function provides()
{
return [];
LaravelNotes::$publishMigrations ? $this->publishMigrations() : $this->loadMigrations();
}
}
10 changes: 2 additions & 8 deletions tests/LaravelNotesServiceProviderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,13 @@ public function it_can_be_instantiated()
{
$expectations = [
\Illuminate\Support\ServiceProvider::class,
\Arcanedev\Support\ServiceProvider::class,
\Arcanedev\Support\PackageServiceProvider::class,
\Arcanedev\Support\Providers\ServiceProvider::class,
\Arcanedev\Support\Providers\PackageServiceProvider::class,
LaravelNotesServiceProvider::class,
];

foreach ($expectations as $expected) {
static::assertInstanceOf($expected, $this->provider);
}
}

/** @test */
public function it_can_provides()
{
static::assertSame([], $this->provider->provides());
}
}

0 comments on commit 5599323

Please sign in to comment.