Refresh expected output #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
reviewed
Jan 31, 2025
|
Ok looks like we need both cryspen/libcrux#782 and FStarLang/karamel#527 to get kyber to pass. Wonder in what order I should merge these? @Nadrieril can you remind me what to do in these situations...? I forgot. Thanks! |
|
Either way around is good I think. I'd probably merge eurydice first since eurydice is more central to libcrux's CI than vice-versa so it's more important to get the libcrux side right. |
|
Great. So we override CI just for this one? |
|
yep |
|
temporarily changed the settings to allow administrators to bypass rules |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the eurydice build