Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full screen #7

Open
AndersDJohnson opened this issue Jun 30, 2015 · 3 comments
Open

Full screen #7

AndersDJohnson opened this issue Jun 30, 2015 · 3 comments
Assignees
@AndersDJohnson
Labels
enhancement help wanted

Comments

@AndersDJohnson
Copy link
Owner

Perhaps like dimsemenov/photoswipe.
@AndersDJohnson AndersDJohnson self-assigned this Jul 4, 2015
AndersDJohnson pushed a commit that referenced this issue Jul 5, 2015
@adjohnson916
Initial fullscreen support. Relates to #7.
f828187
@AndersDJohnson AndersDJohnson changed the title Full screen mode Full screen Jul 5, 2015
AndersDJohnson pushed a commit that referenced this issue Jul 5, 2015
@adjohnson916
Initial fullscreen support. Relates to #7.
0bedfef
AndersDJohnson pushed a commit that referenced this issue Jul 5, 2015
@adjohnson916
Initial fullscreen support. Relates to #7.
c6b05a2
AndersDJohnson pushed a commit that referenced this issue Jul 5, 2015
@adjohnson916
Remove unneeded controls from inner example. Relates to #7.
d4403d8
AndersDJohnson pushed a commit that referenced this issue Jul 5, 2015
@adjohnson916
Remove unneeded controls from inner example. Relates to #7.
1595798
@AndersDJohnson
Copy link
Owner Author

Note: An issue with experimental implementation so far—scale does not maintain proportions when in-page element has different dimensions than screen.
Could be fixed with #13.

@AndersDJohnson AndersDJohnson mentioned this issue Jul 5, 2015
Open
AndersDJohnson added a commit that referenced this issue Mar 21, 2019
@AndersDJohnson
Initial fullscreen support. Relates to #7.
9b8d472
AndersDJohnson added a commit that referenced this issue Mar 21, 2019
@AndersDJohnson
Remove unneeded controls from inner example. Relates to #7.
a2c0ab9
@lamp5
Copy link

lamp5 commented Dec 23, 2019

Any updates about full screen functionality??

@AndersDJohnson
Copy link
Owner Author

Any updates about full screen functionality??

@lamp5 No, I haven't been adding features to this library lately. Would you like to take a stab implementing full screen functionality? I might recommended screenfull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndersDJohnson AndersDJohnson

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndersDJohnson @lamp5