Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Function name/header casing causes thrift crash #9

Open
mduleone opened this issue Jun 9, 2016 · 0 comments
Open

Function name/header casing causes thrift crash #9

mduleone opened this issue Jun 9, 2016 · 0 comments

Comments

@mduleone
Copy link

mduleone commented Jun 9, 2016

When [email protected] receives an error and tries to call the function on the client object through client['recv_' + header.fname](message, header.mtype, dummy_seqid); (line #83 of thrift/lib/thrift/connection.js of [email protected]), header.fname = 'log'. The associated function is defined here: https://github.com/Applifier/node-scribe/blob/master/lib/gen-nodejs/scribe.js#L156, as recv_Log (capital L instead of lowercase like header.fname). This causes [email protected] to choke and the app to crash.

Issue #7 would resolve this issue for the most part, as the latest version of thrift checks for the existence of client['recv_' + header.fname] before invoking it, https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/connection.js;h=23cb01c79b6b839f020bfcb67bc0875221e94564;hb=HEAD#l138

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant