Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile? #182

Closed
818S opened this issue May 20, 2021 · 4 comments
Closed

Dockerfile? #182

818S opened this issue May 20, 2021 · 4 comments

Comments

@818S
Copy link

818S commented May 20, 2021

Saw a pull request for this here #93 but there hasn't been a update for years

So are there any plans to officially ship a Dockerfile for this to simplify the installation and improve reliability?

Doing so would also make it more cross-platform.

@818S 818S changed the title Dockerfile Dockerfile? May 20, 2021
@jtagcat
Copy link

jtagcat commented May 20, 2021

Don't open up a duplicate issue please.

@ivan
Copy link
Contributor

ivan commented May 21, 2021

I don't use Docker and there hasn't been anyone else around to do the technical leadership necessary to get Docker support included and maintained here. This is not just about making a Docker container, but also fully documenting all the equivalent usage in the README, which would probably involve one container per grab-site process. For cross-platform installation, I recommend installing grab-site from nixpkgs. This should work on any Linux and macOS (though more cumbersome).

@ivan ivan closed this as completed May 21, 2021
@jtagcat
Copy link

jtagcat commented May 21, 2021

Make a fork / start your own.

@acrois
Copy link

acrois commented Jul 21, 2021

What I am developing here works: https://github.com/acrois/grab-site/tree/feature/dockerfile it includes #149 into my branch and then I am updating it to include best practices and I am including it in the plan outline at #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants