Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths to symlinks are resolved to their real path #1

Open
Axlefublr opened this issue Dec 20, 2023 · 0 comments
Open

Paths to symlinks are resolved to their real path #1

Axlefublr opened this issue Dec 20, 2023 · 0 comments

Comments

@Axlefublr
Copy link
Owner

The call to std::fs::canonicalize makes it so it's possible to specify relative paths like ../somepath while not being in the repo root, for example.

The downside is that to make that happen, it needs to resolve symlinks (. and .. are hardlinks), so this includes any symlinks you might be providing the path to: you're going to get a link to the real file, rather than to the symlink (if the symlink points to something in the git repository, otherwise you're gonna get jumbled up garbage)

PRs are super welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant