Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential high loads against TXE in noir-projects+test-contracts with multi-threading #11232

Open
jeanmon opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
C-CI Component: continuous integration

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Jan 15, 2025

In a recent PR, I experienced several times failure on ./noir-projects+test-contracts
By running the "full test" locally on mainframe (in noir-projects/noir-contracts):
NARGO_FOREIGN_CALL_TIMEOUT=300000 ../../noir/noir-repo/target/release/nargo test --silence-warnings --oracle-resolver http://localhost:8080/
I got similar failures again. Alvaro helped me and found out that by running the tests separately such as:

NARGO_FOREIGN_CALL_TIMEOUT=300000 ../../noir/noir-repo/target/release/nargo test --silence-warnings --oracle-resolver http://localhost:8080/ --package token_contract burn_private

or by limiting the number of thread to 1 --test-threads=1,
these tests were passing. After multiple reruns it became green on CI.
What Alvaro is suspecting is too much load to the TXE which might lead to some flake failures. Possibly, limiting this test with less threads might be a solution.

@jeanmon jeanmon added the C-CI Component: continuous integration label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-CI Component: continuous integration
Projects
None yet
Development

No branches or pull requests

2 participants