feat: Packable trait #11136
Open
feat: Packable trait #11136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
force-pushed
the
01-09-feat_packable_trait
branch
3 times, most recently
from
6a3b38f to
2c8f7e1
Compare
benesjan
force-pushed
the
01-09-feat_packable_trait
branch
from
2c8f7e1 to
67fafc2
Compare
benesjan
changed the base branch from
master
to
01-10-refactor_using_u128_in_contract_function_args
|
Would this require users to implement Does it make sense to add this blanket implementation, so users are not forced to impl<let N: u32> Packable<N> for T
where
T: Serialize<N> + Deserialize<N>
{
fn pack(self) -> [Field; N] {
self.serialize()
}
fn unpack(packed: [Field; N]) -> Self {
Self::deserialize(packed)
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11285
Fixes #7728