Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming get_json() in EventGridEvent and EventGridOutputEvent #159

Open
pjung-bosch opened this issue Dec 21, 2022 · 0 comments

Comments

@pjung-bosch
Copy link

Both mentioned classes have methods called get_json which return the classes __data field. This seems odd for two reasons:

  1. They don't actually return JSON but a dict (if the typing hints in __init__ are correct). In any case this is a major source of confusion.
  2. All other getters are implemented as properties. (So why not just do the same here?)

def get_json(self) -> typing.Any:
return self.__data

def get_json(self) -> typing.Any:
return self.__data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant