Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Change content iterating in _download_async.py, add decompression live tests against compressed dataset #39755

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vincenttran-msft
Copy link
Member

  • Change from response.load_body() and response.body() in _download_async.py to access content, as this method does not respect the decompress param passed to download_blob API
    • This was resolved by using the iterator directly.
    • An if-else block was added to handle the general hotpath and the validate_content=True path (where the body would have been loaded previously for MD5 check)
  • Test cases were added for both sync and async for the compressed data + decompress=T/F scenario.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Feb 15, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@vincenttran-msft
Copy link
Member Author

/azp run python - storage - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants