Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ai codeowners #39789

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Update ai codeowners #39789

merged 2 commits into from
Feb 21, 2025

Conversation

kingernupur
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kingernupur kingernupur requested review from jayesh-tanna and achauhan-scc and removed request for jayesh-tanna February 19, 2025 05:33
Copy link
Member

@kashifkhan kashifkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cant remove the team entirely. We should add granular level access for the folks who are still DRI for their respective projects

@kingernupur
Copy link
Member Author

we cant remove the team entirely. We should add granular level access for the folks who are still DRI for their respective projects

@kashifkhan I haven't removed the team entirely. There are still relevant team members in the AI Service label. I have modified the to remove my team members since we are getting incorrectly tagged in AI issues like these AI Project client says "Invalid tool value(s): azure_function" · Issue #39778 · Azure/azure-sdk-for-python. We do not currently add value to these tags.

Me and my team are still tagged for ML code path owners in the same file.

@kashifkhan
Copy link
Member

we cant remove the team entirely. We should add granular level access for the folks who are still DRI for their respective projects

@kashifkhan I haven't removed the team entirely. There are still relevant team members in the AI Service label. I have modified the to remove my team members since we are getting incorrectly tagged in AI issues like these AI Project client says "Invalid tool value(s): azure_function" · Issue #39778 · Azure/azure-sdk-for-python. We do not currently add value to these tags.

Me and my team are still tagged for ML code path owners in the same file.

@kingernupur thanks for confirming :) So there are no other granular level changes at the ai project level, iow anything ml will get tagged to your team, anything ai wont ?

@kingernupur
Copy link
Member Author

we cant remove the team entirely. We should add granular level access for the folks who are still DRI for their respective projects

@kashifkhan I haven't removed the team entirely. There are still relevant team members in the AI Service label. I have modified the to remove my team members since we are getting incorrectly tagged in AI issues like these AI Project client says "Invalid tool value(s): azure_function" · Issue #39778 · Azure/azure-sdk-for-python. We do not currently add value to these tags.
Me and my team are still tagged for ML code path owners in the same file.

@kingernupur thanks for confirming :) So there are no other granular level changes at the ai project level, iow anything ml will get tagged to your team, anything ai wont ?

That's right. If and when my team starts contributing to anything under AI in this repo, I will tag my team again to more granular labels :)

@kingernupur kingernupur reopened this Feb 21, 2025
@kingernupur kingernupur merged commit 3703a8f into Azure:main Feb 21, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants