Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please review: Static code analysis results by coverity #244

Open
yxiang92128 opened this issue Mar 15, 2019 · 4 comments
Open

Please review: Static code analysis results by coverity #244

yxiang92128 opened this issue Mar 15, 2019 · 4 comments
Assignees

Comments

@yxiang92128
Copy link

Our organization requires us to scan all open source SDKs by coverity.
After excluding benign/false positive issues and other performance related issues such as Passing large sized parameter by value, I've patched several issues shown as attached mainly in the areas:

Uninitialized member variables.
Uncaught exceptions.
Unchecked return values

Can somebody please verify and if possible integrate the patches?

Thanks.
azure_storage_cpp_coverity_patches.txt

@katmsft
Copy link
Member

katmsft commented Mar 19, 2019

I think @EmmaZhu is currently investigating on it. Please stay tuned.

@EmmaZhu
Copy link
Member

EmmaZhu commented Mar 22, 2019

Hi @yxiang92128 ,

The change seems fine to me. Could you send a PR to us?

Thanks
Emma

@yxiang92128
Copy link
Author

Hi @EmmaZhu ,

Currently we don't the test/unittest infrastructure set up in our dev environment (SLES12SP3). Would you be able to merge the patch into your dev branch and prepare a PR?

Thanks,

Yang

@EmmaZhu
Copy link
Member

EmmaZhu commented May 6, 2019

@yxiang92128
I've created a PR for your change. Could you help to take a reviewing to see whether there's anything I missed?

#256

Thanks
Emma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants