Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: avm/res/network/azure-firewall - enhance documentation for parameter hubIPAddresses #3872

Closed
1 task done
janegilring opened this issue Dec 3, 2024 · 4 comments · Fixed by #3880
Closed
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request

Comments

@janegilring
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Feature Request

Module Name

avm/res/network/azure-firewall

(Optional) Module Version

No response

Description

The documentation for the following parameter should be improved:

Parameter Type Description
hubIPAddresses object IP addresses associated with AzureFirewall. Required if virtualHubId is supplied.

There are no information about the schema for the parameter, and looking at the Bicep code reveals no information about the expected syntax:
https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/network/azure-firewall/main.bicep#L296

In order to determine this, we had to lookup the documentation:

    hubIPAddresses: {
      privateIPAddress: 'string'
      publicIPs: {
        addresses: [
          {
            address: 'string'
          }
        ]
        count: int
      }
    }

(Optional) Correlation Id

No response

@janegilring janegilring added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 3, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Dec 3, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Dec 3, 2024
Copy link

@janegilring, thanks for submitting this issue for the avm/res/network/azure-firewall module!

Important

A member of the @Azure/avm-res-network-azurefirewall-module-owners-bicep or @Azure/avm-res-network-azurefirewall-module-contributors-bicep team will review it soon!

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@janegilring janegilring changed the title [AVM Module Issue]: [AVM Module Issue]: avm/res/network/azure-firewall - enhance documentation for parameter hubIPAddresses Dec 3, 2024

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Dec 6, 2024
@hundredacres hundredacres removed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Dec 6, 2024
@eriqua
Copy link
Contributor

eriqua commented Dec 6, 2024

Related to the more general #3641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Feature Request ➕ New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants