Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Icon in Mobile View is slightly detached #5204

Open
whoamiafterall opened this issue Sep 17, 2024 · 1 comment
Open

Search Icon in Mobile View is slightly detached #5204

whoamiafterall opened this issue Sep 17, 2024 · 1 comment

Comments

@whoamiafterall
Copy link

Describe the Bug

Bildschirmfoto vom 2024-09-17 19-17-44

This happens only in mobile view of Search Results.

Steps to Reproduce

  1. Go to Search
  2. Search something
  3. Click Inspect and mobile view or resize window to mobile
  4. See the Problem occur

Expected Behaviour

The Icon should stay inside the Search Bar.

Screenshots or Additional Context

No response

Browser Details

Firefox 130.0 (64.bit)

Exact BookStack Version

v24.05.4

@ninaa-e
Copy link

ninaa-e commented Sep 18, 2024

We solved this issue for us by adding an tabindex="-1" in all.blade.php to the Button/Searchicon element.
The line looks like this in the End <button tabindex="-1" type="submit">@icon('search')</button>

The reason this works is, that if this is added, a css rule that the searchbar in the header uses will apply here.

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants