Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_gif_thumbnail_generation fails after release #5208

Open
ramel-contria opened this issue Sep 19, 2024 · 0 comments
Open

test_gif_thumbnail_generation fails after release #5208

ramel-contria opened this issue Sep 19, 2024 · 0 comments

Comments

@ramel-contria
Copy link

ramel-contria commented Sep 19, 2024

Describe the Bug

Since the latest release of BookStack, the test_gif_thumbnail_generation test fails and returns the following:

1) Tests\Uploads\ImageTest::test_gif_thumbnail_generation
Failed asserting that 2 matches expected 1.

I think it might be a dependancy through composer install that makes the test fail.

Steps to Reproduce

  1. git pull origin release
  2. composer install
  3. php artisan migrate --database=mysql_testing
  4. php artisan db:seed --class=DummyContentSeeder --database=mysql_testing
  5. php vendor/bin/phpunit --filter test_gif_thumbnail_generation

Expected Behaviour

Expected would be that the test would not fail.

Screenshots or Additional Context

We are currently planning on using BookStack for our company to use as a know-how tool, and are adding some custom code through the theming functionality. For this, we use the release branch as a base and not the developent, since we do not want yet to be supported functions on our end. During our pipelines, we test next to our own tests the regular tests aswell, and this is where we noticed the problem with the test.

Browser Details

No response

Exact BookStack Version

v.24.05.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants