Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comma behaviour has changed between 4.3.1 and latest #782

Open
tom-thorne opened this issue May 12, 2022 · 0 comments
Open

Trailing comma behaviour has changed between 4.3.1 and latest #782

tom-thorne opened this issue May 12, 2022 · 0 comments
Assignees
Labels

Comments

@tom-thorne
Copy link

tom-thorne commented May 12, 2022

Version 4.3.1 format stream used to output trailing commas if csvStream.write(values) was called with too short an array than the first row. That meant that all rows had the same number of commas.

The latest doesn't any longer - so some rows can have fewer commas. This is not useful IMO

Output from 4.3.1

locationName,locationId,categoryGroupId,sort,displayCode,categoryIds,title,shortDescription,imageUrl
,G1-n6,ga,,,,Beer,,
,G2-n5,gb,,,,Red,,
6,loc6,gc,,,,White,,

Output from 4.3.6

locationName,locationId,categoryGroupId,sort,displayCode,categoryIds,title,shortDescription,imageUrl
,G1-n6,ga,,,,Beer
,G2-n5,gb,,,,Red
6,loc6,gc,,,,White

I don't know if this is a bug or a breaking change, but I've reverted to 4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants