Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Selection Search prevents RU AdList JS Fixes from working #255

Open
GCRaistlin opened this issue Mar 13, 2023 · 5 comments
Open

Swift Selection Search prevents RU AdList JS Fixes from working #255

GCRaistlin opened this issue Mar 13, 2023 · 5 comments

Comments

@GCRaistlin
Copy link

Swift Selection Search prevents RU AdList JS Fixes userscript from working: if SSS is on there are ads showed in Yandex.Mail (RU AdList JS Fixes is intended to remove them).

Steps to reproduce the behavior:

  1. Install Tampermonkey extension.
  2. Install RU AdList JS Fixes.
  3. Register an Yandex account. If you don't want to for some reason, I can provide one for you.
  4. Disable Swift Selection Search.
  5. Log in to Yandex. Change the language to English by clicking on the flag in the right lower corner.
  6. Click on Mail icon at the top of the screen.
    There will be no ads in the left part of the screen.
  7. Enable Swift Selection Search and reload the Yandex page.
    There will be ads in the left part of the screen.

System info:

  • Browser: Firefox x64
  • Browser version: 89.0.2
  • System: Windows 8.1 x64
@CanisLupus
Copy link
Owner

CanisLupus commented Apr 4, 2023

Hey @GCRaistlin! Sorry for the super late reply.

I'm not sure what to do about this report. I really appreciate the level of detail in your steps, but this feels like a bit of a special issue. It involves using a script through Tampermonkey and a website I have no account on (though I appreciate you providing an account if necessary), which is a bit too much for me, especially with the unknown risks of scripts.

But let me try to understand. There is no fundamental reason I see that ads would be showing just by enabling SSS, but that could of course be something I didn't think of.

  1. Does this happen without ever opening the SSS popup by selecting some text? That is the moment that SSS actually alters the page.

  2. Can you tell me if adding *yandex.ru to the "Website blocklist" in the SSS settings still causes the problem? Or if that isn't the proper URL, the proper one. I know it's annoying to make SSS not work on some website or specific page but it may solve it, at least.

image

  1. What if you change "Opening behaviour" to "Off (never)"? Not suggesting this as a solution, just would like to know what causes the problem exactly.

image

Thanks for any info you can provide!
Daniel

@GCRaistlin
Copy link
Author

  1. Yes, it does.
  2. Adding *yandex.ru to the "Website blocklist" doesn't solve the problem (while causes SSS to stop working on affected pages).
  3. (seems to be missed).
  4. No effect.

@CanisLupus
Copy link
Owner

CanisLupus commented Apr 4, 2023

Thanks for checking! Number 4 was indeed supposed to be 3. Something happened to the numbered list when I pasted the images and I didn't notice 😅

Interesting, so SSS doesn't need to change the page contents. Can you check if you have this option enabled?

image

If you do, can you try disabling it along with "Opening behaviour" set to "Off (never)"? Those two options disabled will remove any injection of the SSS content script in the page and we can see what happens. Maybe you had them both disabled already in my last message, though.

I've tried looking a bit into the JavaScript of "RU AdList JS Fixes" but nothing was obviously a problem at a first glance.

@GCRaistlin
Copy link
Author

It is off.

@CanisLupus
Copy link
Owner

Got it. Sorry, I don't currently see a reason for this to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants