Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Tracking sandcastle broken in 1.126 #12465

Open
srcejon opened this issue Feb 6, 2025 · 3 comments · May be fixed by #12467
Open

Entity Tracking sandcastle broken in 1.126 #12465

srcejon opened this issue Feb 6, 2025 · 3 comments · May be fixed by #12467

Comments

@srcejon
Copy link
Contributor

srcejon commented Feb 6, 2025

What happened?

The Entity Tracking sandcastle appears to be broken in 1.126. Worked in 1.125.

https://sandcastle.cesium.com/?src=Entity%20tracking.html

It doesn't appear to track either the satellite or drone in any reference frame.

If I comment out the following lines:

satellite.viewFrom = new Cesium.Cartesian3(-300, 20, 100);
drone.viewFrom = new Cesium.Cartesian3(-50, 0, 5);

It starts tracking.

Reproduction steps

  1. View https://sandcastle.cesium.com/?src=Entity%20tracking.html
  2. Click drone
  3. Camera doesn't track drone
    ...

Sandcastle example

https://sandcastle.cesium.com/?src=Entity%20tracking.html

Environment

Browser: Edge / Firefox / Chrome
CesiumJS Version: 1.126
Operating System: Windows 11

@jjspace
Copy link
Contributor

jjspace commented Feb 6, 2025

I can confirm the issue is happening but haven't really looked into it. At initial glance I do wonder if it's related to this pr #12429? It was targeted at some changes to tracking entities so it's possible.

@jfayot
Copy link
Contributor

jfayot commented Feb 6, 2025

You're right @jjspace ! Git bisect points to commit f01671e

@jfayot
Copy link
Contributor

jfayot commented Feb 6, 2025

More specifically, restoring boundingSphereScratch instead of entityView.boundingSphere inside CesiumWidget._onTick fixes this issue...

jfayot pushed a commit to jfayot/cesium that referenced this issue Feb 7, 2025
@jfayot jfayot linked a pull request Feb 7, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants