Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable sharability among critic and actor #2

Open
PeiYingjun opened this issue Aug 3, 2018 · 2 comments
Open

variable sharability among critic and actor #2

PeiYingjun opened this issue Aug 3, 2018 · 2 comments

Comments

@PeiYingjun
Copy link

Thanks for reply, I have been busy at another project last few days, recently I get spare time.
I have noticed that at comm_net, the variables of communication part(maybe along with encoder part) are not shared between critic and actor,
I don't know whether it should be like these way in regular algorithms trained by DDPG like comm_net?

@Coac
Copy link
Owner

Coac commented Aug 3, 2018

Well, I am not sure, but it seems that lots of actor-critic architecture shared the core layers and just use different heads. The two parts need to understand the environment, so sharing the features of the world might be faster for training.
If you have time to try it, do not hesitate to make a PR

@PeiYingjun
Copy link
Author

Exactly, I'm trying to rewrite the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants