Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up with email #52

Closed
crysfel opened this issue Sep 13, 2018 · 27 comments
Closed

Sign up with email #52

crysfel opened this issue Sep 13, 2018 · 27 comments
Assignees

Comments

@crysfel
Copy link
Member

crysfel commented Sep 13, 2018

As a user I want to sign up into the app using my email address. Name, Email, Password and a checkbox to accept the terms and conditions.

Once I have entered my data, I want to click the Sign Up button to create my account. After the server successfully create my account, I should be redirected to the main page (TBD, maybe profile page? Or search?).

When implementing this, make sure to create a components/Textfield component, we want this component to be reusable in other parts of the application.

const classes = {
  root: styles.someCustomClassForTheRootElement,
  input: styles.customCssForTheInput,
  label: 'something-here',
};

<Textfield value={value} onChange={onChange} classes={classes} label="Email" />

Same for the Checkbox, we want reusable components.

The scope of this class is only to define the UI in the clientside. For the actual login in the backend take a look at:

Coding-Coach/coding-coach-api#9
Coding-Coach/coding-coach-api#12

image

@jagzviruz
Copy link
Member

Using social login will eliminate the need for email validation and the need to securely store passwords.

@crysfel
Copy link
Member Author

crysfel commented Sep 14, 2018

@jagzviruz there's another task for that coming up ;) but we are allowing users to use their email to signup as well.

@pawansingh972
Copy link

What about Textfield and checkbox styling?

@gibsonhan
Copy link

Is anyone working on this?

@dhrubesh
Copy link

I'll be taking this up. @emmawedekind Can you assign this to me?

@crysfel
Copy link
Member Author

crysfel commented Sep 30, 2018

We don't have the design for this or wireframes, I don't want to waste your time on something that we might ended up removing xD

@dhrubesh
Copy link

@crysfel no problem, I'll be working on this once the design is ready.

@gibsonhan
Copy link

Hey @dhrubesh, I inquired about this issue first. I am not sure if you ignoring my comment above...

@emmabostian
Copy link
Collaborator

I will assign this to both of you @gibsonhan and @dhrubesh . Please coordinate together.

@gibsonhan
Copy link

gibsonhan commented Sep 30, 2018

🔨🔪🔨I DEMAND ISSUE ASSIGNMENT BY COMBAT 🔨 🔪🔨. Jokes aside. Will do.

@Ragzzy-R
Copy link

This should be official code of conduct when requesting to assign task. 😂🤣

@emmabostian
Copy link
Collaborator

I agree. Let me talk with @crysfel . Ultimately I'd love for people to work together but I also understand this is difficult based on locations.

@emmabostian
Copy link
Collaborator

But also... we're not ready to begin this task yet as the designs are in-progress.

@dhrubesh
Copy link

@gibsonhan Let's work together if it's fine with you?

@FacundoGFlores
Copy link

Is there any requirement for social login? Any service like Auth0 or Firebase are going to be used?

@crysfel
Copy link
Member Author

crysfel commented Oct 5, 2018

Just to be clear, this task is only to build the UI in the frontend, we still don't have the final design so please be patient.

@emmabostian
Copy link
Collaborator

Yes, I am working on this, but the Privacy Policy, Cookies, and Terms & Conditions have higher priority.

@emmabostian
Copy link
Collaborator

This issue is now ready for development. Note: This is only the mobile design; the desktop version will have different styling. Additionally, this story only covers the email sign up.

@emmabostian emmabostian mentioned this issue Dec 23, 2018
2 tasks
@emmabostian
Copy link
Collaborator

Hi, what's the status?

@swissarmykirpan
Copy link
Collaborator

swissarmykirpan commented Jan 22, 2019

I want to pull this back into backlog because it needs refining, which I apparently can't do since I don't have permissions to the repo @crysfel

@emmabostian
Copy link
Collaborator

emmabostian commented Jan 22, 2019

What do you mean it needs refining...? We're not giving write access to anyone, sorry. That shouldn't stop you from developing. @swissarmykirpan

@swissarmykirpan
Copy link
Collaborator

@emmawedekind @crysfel

  1. Since we have opted to use Auth0 - we no longer need to implement these pages in the front-end stack. Auth0 has the concept of hosted pages - https://auth0.com/docs/hosted-pages/login
  2. The epic needs to be reorganised to consider that information
  3. The epic needs to contain information about the entire Signup Flow, all the steps, such as:

Each of these bits all fulfill the completion of Signup. It will allow us to create stories for each of the bits of work. At the moment this all looks haphazard. There are multiple issues open for the same thing, and it's incoherent and so it's very difficult for:

  1. A new person to come onboard and see what is what
  2. For a stakeholder like @emmawedekind to understand what progress has been made
  3. For the person who has identified what work needs to be done.

I apologise if this is overly critical, but we can do a lot better organising the work.

@emmabostian
Copy link
Collaborator

I have given you write access @swissarmykirpan. You are now welcome to update the Epic with more detailed information: #33.

Please let me know if you have any questions, thanks!

@moshfeu
Copy link
Member

moshfeu commented Jan 24, 2019

@swissarmykirpan What about https://docs.google.com/document/d/1DbdRZBsyjbeBl9vddUyXCUWsgwdgyyUY2NIQitf3_Z0/edit?disco=uiAAAACIR2Yl4? (I know it's old but there is no conclusion there..)

@swissarmykirpan
Copy link
Collaborator

@crysfel and I had another discussion about this and we came to the conclusion that the out of box functionality that Auth0 provides is far superior to having to create all the functionality manually. In regards to the concerns:

  1. It's a pain to setup - I agree in the past the documentation was light. This has changed significantly now. It is much easier to follow.
  2. Bundle size for Auth0Lock - I agree the bundle is massive and we won't be using this. We will be using Universal Login/hosted pages - https://auth0.com/docs/hosted-pages
  3. Security Breach - This happens to everyone. https://auth0.com/docs/security/bulletins - they are completely transparent about it, which is promising.
  4. A point to add, Atlassian are one of their customers (amongst others)

@moshfeu
Copy link
Member

moshfeu commented Jan 24, 2019

Sounds good.
So it will be better to update the doc as well to avoid confusing.
(Or the doc is not relevant anymore?)

@HighWatersDev
Copy link

@swissarmykirpan @crysfel is there an issue for back-end implementation of Auth0? Will be happy to help there.

@crysfel crysfel closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests