Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Remove terminal.restore API #933

Open
webfiltered opened this issue Feb 17, 2025 · 0 comments
Open

[DevTask] Remove terminal.restore API #933

webfiltered opened this issue Feb 17, 2025 · 0 comments

Comments

@webfiltered
Copy link
Contributor

webfiltered commented Feb 17, 2025

Terminal keeps an array of raw output strings as the terminal buffer, and restore() returns the raw strings when requested. They are fed via IPC on a delay to the frontend. As we are using a full pty, this design causes various issues.

We should remove this raw buffer and instead utilise the pty buffer to handle save/restore - thus removing the need to replay every control character at potentially different width/height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant