Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Investigate node.widgets_values set as object #638

Open
webfiltered opened this issue Feb 27, 2025 · 0 comments
Open

[DevTask] Investigate node.widgets_values set as object #638

webfiltered opened this issue Feb 27, 2025 · 0 comments

Comments

@webfiltered
Copy link
Contributor

webfiltered commented Feb 27, 2025

At least one extension is using an object in place of an array for widget_values:

https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/blob/4c7858ddd5126f7293dc3c9f6e0fc4c263cde079/web/js/VHS.core.js#L31-L159

This causes repeat issues, as the actual types defined in the core code are invalid. All tests and expectations are nominal - until the code reaches consumers, where the extensions are loaded, and things break - cannot use app at all in some instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant