Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter does not restore properly after dimension change #1130

Closed
rbouckaert opened this issue Oct 2, 2023 · 0 comments
Closed

Parameter does not restore properly after dimension change #1130

rbouckaert opened this issue Oct 2, 2023 · 0 comments

Comments

@rbouckaert
Copy link
Member

For a RealParameter, an operator can propose a change of dimension through setDimension().
When store() is called by the MCMC algorithm, the stored value resizes to the new dimension.
If the proposal is rejected, at restore(), the stored value still has the new dimension, but it should resize to the old dimension.

When the new dimensions is larger than the old dimension, it should be possible to cut down to the old dimension based on the stored values. When the old dimension is larger than the new dimension, the information at the highest dimension(s) are lost.

The problem occurs because setDimension() does not call startEditing(), but it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant