add: allow existing bucket names as array #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanjpayne
reviewed
Apr 23, 2024
There was a problem hiding this comment.
I've been working on this same approach and there are two issues:
- Buckets outside of current Region context will throw 301 in data.aws_s3_bucket.bucket. This means the user can only provide buckets in the same region as the current AWS CLI configuration.
- Running more than once (say to configure for multiple regions) will fail because the IAM resource names are not unique for each run.
A fix could be:
- make any global resource names unique
- require that the existing.sh is run for each region separately
Issues with this approach: - the tf would need to be copied in a new location each time as the existing state file will cause the new region to fail
- duplicate iam resources is not ideal
|
a better approach would be to use modules. one module for infra, one module to set up bucket. infra module is only called once, while the bucket module is called foreach and everytime a bucket needs to be added going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275
This PR allows you to apply terraform code one time to scan several existing s3 buckets.
existing.shscript will ask you to provide existing s3 bucket names in a format like below.Bucket names: s3-bucket-protection-test s3-bucket-protection-test-test