-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom hooks in Redis plugin #1168
Comments
Definitely something we've been looking at doing. The main blocker for this one has been figuring out what should be passed to the hook, but otherwise it shouldn't be too difficult to add.
We are planning to add the origin tags automatically in a later release. I don't have a timeline but it should happen in the next few months. |
Thanks @rochdev! How can we stay informed so we know when this has been done? |
Right now these are generated in the backend but we'll be moving them to the tracer, so you'll see it in the release notes. |
@opeyemi-paystack Are you using |
@rochdev I am using |
@rochdev when this is added, will we be able to use it to filter in Analytics? Or will it behave like the current origin tag, which can't? |
Hey @rochdev, is there any update on this? Been looking forward for some months now. |
+1! I would like to add a TimeSeries graph to my dashboard with the latencies for different resource_names, but filtering these to which are called from my specific service. Any information would be appreciated! :) |
Hey @rochdev, is there any update on this? |
@opeyemi-paystack No update right now unfortunately. Since it's unclear at this point when this will be implemented in the backend as originally mentioned, I'd like to understand a bit better your use case to make sure a hook would actually work. Do you just need to add the HTTP route to the Redis span as a tag? If that's the case, can you give more details about how you will be using this in the UI? |
Hi!
A use-case we have is to graph origin service and endpoints to a Redis service. However, we've been informed that it's not possible to graph @trace.origin.resource_name APM queries in a dashboard. There are two possible solutions:
A custom hook in the Redis plugin, so we can set a custom span tag with the origin resource name. Of course this would probably require being able to get the root span in the hook, as I doubt the parameters passed into the hook callback would be
req
andres
since it's not a http plugin.The plugin taking care of this by default, by setting tags which contain the origin command (e.g.
http.request
,web.request
) and the origin resource name (e.g. post_/transaction etc). The origin service is already intuitive since the redis service is named from it.Happy to hear any other ways this can be resolved.
Cheers!
The text was updated successfully, but these errors were encountered: