You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of hardcoding license text in "metadata.go", would we consider using the License text obtained from GitHub API using github.com/google/go-github?
#242
On this line, variable "rr" points to a "github.Repository" object with a "License" field in which the there is a GitHub URL pointing to the License text.
Would you think that it is better for dh-make-golang to obtain the license text from this URL rather than getting the license text from the hard-coded dictionary in metadata.go?
P.S. For the license example above, the hard-coded dictionary does not even have a bsd-2-clause as its key. As a result, the generated debian/copyright only has a "TODO" under the generated License stanza:
Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Source: https://github.com/go-warnings/warnings
Upstream-Name: warnings.v0
Upstream-Contact: TODO
Files: *
Copyright: 2016
License: BSD-2-clause
Files: debian/*
Copyright: 2025 TODO <TODO>
License: BSD-2-clause
Comment: Debian packaging is licensed under the same terms as upstream
License: BSD-2-clause
TODO
The text was updated successfully, but these errors were encountered:
The text from the GitHub API contains the full license text. For Debian copyright files, we only need the header text for the license. Grabbing it from GitHub would result in the entirety of, for instance, the Apache-2.0 license or GPL-3.0 license being added to the copyright file.
The dictionary can easily be updated for missing licenses.
dh-make-golang/metadata.go
Line 169 in 0846d5a
On this line, variable "rr" points to a "github.Repository" object with a "License" field in which the there is a GitHub URL pointing to the License text.
Would you think that it is better for dh-make-golang to obtain the license text from this URL rather than getting the license text from the hard-coded dictionary in metadata.go?
dh-make-golang/metadata.go
Line 34 in 0846d5a
P.S. For the license example above, the hard-coded dictionary does not even have a bsd-2-clause as its key. As a result, the generated debian/copyright only has a "TODO" under the generated License stanza:
The text was updated successfully, but these errors were encountered: