Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managers should be able to edit other managers #41

Open
devincowan opened this issue Mar 16, 2023 · 1 comment
Open

Managers should be able to edit other managers #41

devincowan opened this issue Mar 16, 2023 · 1 comment
Assignees
@jscottsf

Comments

@devincowan
Copy link
Collaborator

devincowan commented Mar 16, 2023 •
edited
Loading

Perhaps this is a non-issue. Seems like CASL does what we want and managers can edit other managers. However, this makes it look like that isn't the case:
https://github.com/DendraScience/dendra-web-api/blob/master/src/server/lib/rules.js#L223
@devincowan devincowan mentioned this issue Mar 16, 2023
Merged
@devincowan devincowan changed the title Manager role should not be able to edit sys_admin or managers (only patch/edit users) Should managers be able to edit other managers? Mar 16, 2023
@devincowan
Copy link
Collaborator Author

we decided managers can edit other managers
can elevate users to managers
can demote managers to users

Manager can't do anything to a sys_admin

@devincowan devincowan changed the title Should managers be able to edit other managers? Managers should be able to edit other managers Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscottsf jscottsf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jscottsf @devincowan