Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed double press issue #593 #600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed double press issue #593 #600

wants to merge 1 commit into from

Conversation

ZtormTheCat
Copy link

Now correctly sets trigger_delta and last_controller_event for double press events.

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

Now correctly sets trigger_delta and last_controller_event for double press events and thus closes #593

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

@ZtormTheCat
Changed RegEx expression
0556d3d 
Now correctly sets trigger_delta and last_controller_event for double press events.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hey @ZtormTheCat, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@ZtormTheCat ZtormTheCat changed the title Changed RegEx expression Fixed double press issue #593 Feb 8, 2024
@p4sI
Copy link

p4sI commented Feb 9, 2024

Probably it should also be corrected here

awesome-ha-blueprints/blueprints/controllers/ikea_e2001_e2002/ikea_e2001_e2002.yaml

Line 406 in 9ee5920

trigger_delta: '{{ (as_timestamp(now()) - ((states(helper_last_controller_event) | from_json).t if helper_last_controller_event is not none and (states(helper_last_controller_event) | regex_match("^\{((\"a\": \".*\"|\"t\": \d+\.\d+)(, )?){2}\}$")) else as_timestamp("1970-01-01 00:00:00"))) * 1000 }}'
but I cannot verify because I don't have this controller.

@pfiorentino
Copy link

pfiorentino commented May 3, 2024 •
edited
Loading

Probably it should also be corrected here

awesome-ha-blueprints/blueprints/controllers/ikea_e2001_e2002/ikea_e2001_e2002.yaml

Line 406 in 9ee5920

trigger_delta: '{{ (as_timestamp(now()) - ((states(helper_last_controller_event) | from_json).t if helper_last_controller_event is not none and (states(helper_last_controller_event) | regex_match("^\{((\"a\": \".*\"|\"t\": \d+\.\d+)(, )?){2}\}$")) else as_timestamp("1970-01-01 00:00:00"))) * 1000 }}'

but I cannot verify because I don't have this controller.

Yup! I do have an IKEA e2002 and I can confirm this is also required to make the double click work on the controller.

[Edit]: As far as I can see it has already been created here :) → https://github.com/EPMatt/awesome-ha-blueprints/pull/546/files

@nljuba-eng
Copy link

None of the controllers has a working double click event!
Is this pull request merged already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - Ikea Shortcut Button Double Click does not work
4 participants
@ZtormTheCat @p4sI @pfiorentino @nljuba-eng