Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty state subtitle text is in English #57687

Open
1 of 8 tasks
m-natarajan opened this issue Mar 3, 2025 · 11 comments
Open
1 of 8 tasks

Empty state subtitle text is in English #57687

m-natarajan opened this issue Mar 3, 2025 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@m-natarajan
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

(If you have already a workspace with Expensify Card enabled and you can issue a new card there, you can skip steps 2 - 5)

  1. Change language settings to Spanish
  2. Go to a workspace, enable Expensify Card in More Features
  3. Go to Expensify Card, click Issue New Card, add a new bank account if you don't have any
  4. Choose the bank account from the list
  5. After successful verification you should the Empty State screen
  6. Repeat steps 2 - 4, choose the same bank account as in the previous workspace.
  7. You should see the Empty State screen, with the “Verification in progress…” (or “Verificación en curso…” in Spanish) title.

Expected Result:

Subtitle text should be in Spanish

Actual Result:

Subtitle text is in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

@m-natarajan m-natarajan added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Mar 3, 2025
Copy link

melvin-bot bot commented Mar 3, 2025

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Mar 3, 2025

Image

Able to repro this. Same steps. Please assign me C+ as per https://expensify.slack.com/archives/C02NK2DQWUX/p1741025004934879

@parasharrajat

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

⚠️ @parasharrajat Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

@samranahm

This comment has been minimized.

@m-natarajan
Copy link
Author

Proposal by @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Subtitle text is not translated

What is the root cause of that problem?

We don't set Spanish translation for expensifyCard.verifyingTheDetails

verifyingTheDetails: "We're verifying a few details. Concierge will let you know when Expensify Cards are ready to issue.",

What changes do you think we should make in order to solve the problem?

Update correct Spanish translation.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Copy link
Contributor

github-actions bot commented Mar 3, 2025

⚠️ @m-natarajan Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

@m-natarajan
Copy link
Author

@parasharrajat @samranahm

My apologies, @dukenv0307 submitted his proposal in slack along with the issue report. I missed to post. Can you please remove your proposals if possible.

@parasharrajat
Copy link
Member

Its fine; @dukenv0307 can take it.

@samranahm
Copy link

@m-natarajan I'm fine too, all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
None yet
Development

No branches or pull requests

6 participants