Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mweb - AlphaNumeric keypad is shown for greater than/less than fields #57690

Open
1 of 8 tasks
lanitochka17 opened this issue Mar 3, 2025 · 2 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 3, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9 1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap Reports → Filter → Total
  3. Try to enter letters in the Greater Than/Less Than field
  4. Note user is not allowed to enter letters
  5. Try to enter numbers in the Greater Than/Less Than field
  6. Note user is allowed to enter numbers

Expected Result:

Since only numbers can be entered in the Greater Than/Less Than field, only a numeric keypad should be displayed

Actual Result:

An alphanumeric keypad is shown, even though only numbers can be entered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6760145_1741025138175.Screenrecorder-2025-03-03-23-19-29-415.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 3, 2025
Copy link

melvin-bot bot commented Mar 3, 2025

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@daledah
Copy link
Contributor

daledah commented Mar 3, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

An alphanumeric keypad is shown, even though only numbers can be entered

What is the root cause of that problem?

In Search filters amount page we didn't specify inputMode for the greater than and less than field

<InputWrapper
InputComponent={AmountWithoutCurrencyInput}
inputID={INPUT_IDS.GREATER_THAN}
name={INPUT_IDS.GREATER_THAN}
defaultValue={greaterThanFormattedAmount}
label={translate('search.filters.amount.greaterThan')}
accessibilityLabel={translate('search.filters.amount.greaterThan')}
role={CONST.ROLE.PRESENTATION}
ref={inputCallbackRef}
uncontrolled
/>

What changes do you think we should make in order to solve the problem?

add inputMode={CONST.INPUT_MODE.NUMERIC} to the fields here:

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants