Room - Newly added mention is not invited to the room when edit mention message

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Create room
2. Mention 2 users
3. Verify Invite them button appears
4. Edit the mention message from step 2 and add another mention
5. Click Invite them button

Expected Result:

All mentioned users should be invited to the room

Actual Result:

User mentioned additionally when edit the message is not invited when use Invite them option

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6760256_1741033349423.Recording__5126.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-03 20:59:01 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Newly added mention is not invited to the room when edit mention message

What is the root cause of that problem?

We pass the same action to resolveActionableMentionWhisper even if the action get edited

App/src/pages/home/report/PureReportActionItem.tsx

Lines 679 to 682 in 589794b

	text: 'actionableMentionWhisperOptions.invite',
	key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE}`,
	onPress: () => resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE),
	isPrimary: true,

What changes do you think we should make in order to solve the problem?

We should explicitly check if the action get changed so that we can pass the updated participants emails to function

const handlePress = useCallback(() => {
    resolveActionableMentionWhisper(reportID, action, CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE);
}, [reportID, action]);


        text: 'actionableMentionWhisperOptions.invite',
        key: `${action.reportActionID}-actionableMentionWhisper-${CONST.REPORT.ACTIONABLE_MENTION_WHISPER_RESOLUTION.INVITE}`,
        onPress: handlePress,
        isPrimary: true,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)