Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests aren't cleaning up the resorces #579

Open
XVincentX opened this issue Dec 14, 2017 · 1 comment
Open

Tests aren't cleaning up the resorces #579

XVincentX opened this issue Dec 14, 2017 · 1 comment
Assignees

Comments

@XVincentX
Copy link
Member

Our test suite has multiple parts where async cleanup resources aren't waited for its completion. This introduces flakyness as well as hardening the things when you want to DRY the things.

Example: close method of express applications are async, and they accept a done parameter.

@XVincentX
Copy link
Member Author

With mocha 4.0 this is now kind of a priority. Mocha now does not exit anymore in case there are pending handles (such as sockets, file descriptors and shit like that).

Therefore, we might really need to clean this up, one per time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant