Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EG should differentiate the error between unauthorized and invalid token #701

Open
djesani opened this issue Apr 18, 2018 · 1 comment
Open
Assignees

Comments

@djesani
Copy link

djesani commented Apr 18, 2018

Currently, if an authenticated endpoint is hit with no access_token, an "UNAUTHORIZED" error is returned, which is correct behaviour.

However, if I hit the same endpoint with a valid access_token but that token has expired, I should get a different error such as "INVALID_TOKEN".

The code must already doing checks against the token to determine its expired, so I presume at that point EG should return a different error.

I think this could be linked in with issue #692 .

@XVincentX
Copy link
Member

They're not linked issues. #692 is about proxy errors — this is an authentication error that's handle per policy.

To close this issue there are couple of modifications needed in both JWT verifier policy as well as the opaque token verification.

@XVincentX XVincentX self-assigned this Apr 19, 2018
@altsang altsang added the ready label Apr 19, 2018
@altsang altsang added this to the 1.9.0 milestone Apr 19, 2018
@altsang altsang removed the ready label Apr 23, 2018
@altsang altsang removed this from the 1.9.0 milestone Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants