Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string shouldn't be allowed as basic-auth/oauth2 custom password #774

Open
kolbinski opened this issue Aug 1, 2018 · 2 comments
Open

Empty string shouldn't be allowed as basic-auth/oauth2 custom password #774

kolbinski opened this issue Aug 1, 2018 · 2 comments
Assignees
@DrMegavolt
Labels
bug

Comments

@kolbinski
Copy link

Now, with empty string as a password, such credential is created.
@kolbinski kolbinski added the bug label Aug 1, 2018
@XVincentX
Copy link
Member

XVincentX commented Aug 1, 2018 via email

@XVincentX
Copy link
Member

Note to self: this requires a lot of efforts.

  1. Make the JSON schema validation on the Admin API
  2. Cleanup the credentials schema (requires an huge refactoring effort to make the thing decent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DrMegavolt DrMegavolt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XVincentX @DrMegavolt @kolbinski