-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect team issue list to API #21
Connect team issue list to API #21
Conversation
resolutionStatus?: string; | ||
} | ||
export async function getTeamNotes( | ||
fetch: any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is fetch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that's a great question and I'm really not familiar enough with Svelte and JS to talk particularly eloquently about it, but at a high level Svelte defines its own fetch
that provides some additional functionality on top of the native fetch
API. To use that with openapi-fetch
, we need to pass it along from the Svelte load()
function.
That pattern is the recommendation from openapi-fetch
:
https://openapi-ts.dev/openapi-fetch/examples#svelte-sveltekit
I am not using it in some places where we aren't using a Svelte load()
function, mostly because I also just don't know how to get access to Svelte's fetch
in those cases.
It is something I want to dig into a bit more too, if only for my own learning
I'm going to come back to this later this week after merging #22 |
@333fred updated with latest swagger spec. Much easier to work with! |
Wires up the team issue list to actual API data instead of mock data.
I tested locally by POSTing some notes manually - UI support for adding notes will be up next.
To properly support this I set up some groundwork for managing the current configured season & event code. It's functional-ish, but at some point it would be great if it worked a bit more automatically (see #20 )