Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in #include generation for internal headers #527

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Fix mistake in #include generation for internal headers #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Bundles.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,10 @@ let direct_dependencies_with_internal files file_of =
| `Internal -> List.mem Common.Internal flags

method! visit_DFunction env cc flags n_cgs n ret name binders body =
(* KPrint.bprintf "function %a: concern us=%b %b %b \n" *)
(* PrintAst.Ops.plid name *)
(* (self#concerns_us flags) *)
(* (List.mem Common.Internal flags) (List.mem Common.Private flags); *)
if self#concerns_us flags then
if is_inline_static name then
super#visit_DFunction env cc flags n_cgs n ret name binders body
Expand Down
2 changes: 1 addition & 1 deletion lib/Output.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ let write_h files public_headers (deps: Bundles.all_deps Bundles.StringMap.t) =
let internal_headers = List.map (fun f -> "internal/" ^ f) internal in
let headers =
if Bundles.StringSet.mem name public_headers then
("../" ^ name) :: internal_headers
("../" ^ name) :: public @ internal_headers
else
public @ internal_headers
in
Expand Down