Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemplateConfigForm: Language for block and allow backwards for location filtering #151

Closed
adamjudd opened this issue Jan 23, 2024 · 1 comment · Fixed by #154
Closed
Assignees

Comments

@adamjudd
Copy link
Contributor

For the location filtering in the TemplateConfigForm element, the language strings for allowing and blocking locations is back to front:

Screenshot 2024-01-23 at 17 52 43

That configuration is actually only allowing NSW, Australia as a selectable region and country for shipping addresses, but the labels suggest that everything else will be allowed except NSW, Australia.

Suggested language string options:

  • Allow specific locations/Block specific locations
  • Block all accept/Allow all except (flipping them around)
  • Only allow.../Allow all except...

I think I prefer the first option? @brettflorio - you have any thoughts?

Copy link

🎉 This issue has been resolved in version 1.25.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants