Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odds and Ends #53

Open
1 of 6 tasks
chrisdicaprio opened this issue Feb 26, 2024 · 0 comments
Open
1 of 6 tasks

Odds and Ends #53

chrisdicaprio opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
LIB for filtering nzshm-model for filtering

Comments

@chrisdicaprio
Copy link
Collaborator

chrisdicaprio commented Feb 26, 2024

Some thoughts on how to improve the classes that have come up while working on them:

  • change member name in source classes from nrml_id to something that is not tied to openquake (be hazard engine agnostic)
  • do we need the type member of the source classes? It's possible to set them to something that doesn't match the class (e.g. "distributed" for a InversionSource)
  • should we even have DistributedSource and InversionSource? Should we just store any meta data (inversion id, etc.) in a class dict?
  • should we at least have a generic base class for sources to use when neither DistributedSource nor InversionSource fits the bill? We may, in the future, have inversions that also include the DSM
  • elevate SLT version2 to 1st class
  • move values to Branch base class (GMCM LTs also have a structure)?
@chrisdicaprio chrisdicaprio added nzshm-model for filtering LIB for filtering labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LIB for filtering nzshm-model for filtering
Projects
None yet
Development

No branches or pull requests

2 participants