Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigation: using NrmlDocument to serialize/deserialize nrml #91

Open
chrisdicaprio opened this issue Aug 4, 2024 · 0 comments
Open

Investigation: using NrmlDocument to serialize/deserialize nrml #91

chrisdicaprio opened this issue Aug 4, 2024 · 0 comments
Labels
LIB for filtering nzshm-model for filtering

Comments

@chrisdicaprio
Copy link
Collaborator

chrisdicaprio commented Aug 4, 2024 •
edited
Loading

NrmlDocument class has from_xml_file() method but no to_xml_file() method. To write source and gmcm xml for OpenQuake we use OpenquakeSimplePshaAdapter build_gmcm_xml() and build_sources_xml(). Better and less redundant to use NrmlDocument methods? We already use NrmlDocument in OpenquakeSimplePshaAdapter.sources_document() (nee config()).

Consider both source and gmcm files
@chrisdicaprio chrisdicaprio mentioned this issue Aug 4, 2024
Closed
5 tasks
@chrisdicaprio chrisdicaprio added nzshm-model for filtering LIB for filtering labels Aug 4, 2024
@chrisdicaprio chrisdicaprio changed the title Q: should we be using source_document() (nee config()) to write to xml rather than building up from raw as in build_sources_xml()? Investigation: using NrmlDocument to serialize/deserialize nrml Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LIB for filtering nzshm-model for filtering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisdicaprio