pytmd_model.format tests in coastal module need updating for latest pyTMD

[jessjaco]

The various tests for pytmd_model.format in coastal.py, e.g.

dea-notebooks/Tools/dea_tools/coastal.py

Line 292 in 0c4268d

if pytmd_model.format in ("OTIS", "ATLAS", "TMD3"):

need to be updated for the new values in pyTMD.model of ATLAS-compact, FES-ascii, FES-netcdf, etc. listed here: https://github.com/tsutterley/pyTMD/blob/0f6a07c8723a67b02eade42feb211df8a78b8321/pyTMD/io/model.py#L148-L158

I believe pyTMD version 2.1.4 is the last working version.

[robbibt]

Thanks @jessjaco - pinning to pyTMD 2.1.4 is the best temporary solution - feel free to raise a PR here pinning that version in our setup.py!

https://github.com/GeoscienceAustralia/dea-notebooks/blob/develop/Tools%2Fsetup.py#L59

We should chat about this in more detail at some point - we're currently in the process of spinning off all our tide modelling to a smaller, easier to install Python package (eo-tides). Should make managing changes to the tide modelling code much easier in the the future!

[jessjaco]

Ok, I noticed some of the recent updates to pyTMD and I'm just trying to stay on top of them. (The addition of the crop functionality helped speed things up a lot.) Looking forward to hearing about the new package!

[jessjaco]

It looks like this was fixed in fe36b0e

[robbibt]

@jessjaco Closing this as all future development will happen in eo-tides: https://github.com/GeoscienceAustralia/eo-tides