Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change call options to get Widget like Icon or SvgPicture instead of passing IconData parameters #532

Open
hajajmaor opened this issue Nov 20, 2023 · 3 comments
Assignees

Comments

@hajajmaor
Copy link
Contributor

No description provided.

@deven98
Copy link
Contributor

deven98 commented Nov 23, 2023

Hey @hajajmaor, I'm not sure I fully understand where you want to make this change.

Can you give me an example snippet which you would ideally like to use and how you have to do it right now?

@hajajmaor
Copy link
Contributor Author

Instead of passing IconData like so:

        ToggleCameraOption(
          call: call,
          localParticipant: localParticipant,
          disabledCameraIcon: Icons.videocam_off_rounded,
          enabledCameraIcon: Icons.videocam_rounded,
        ),

I would like to pass some SvgPicture widgets with custom design:

ToggleCameraOption(
          call: call,
          localParticipant: localParticipant,
          disabledCameraIcon: Assets.icons.cameraOff.svg(),
          enabledCameraIcon: Assets.icons.cameraOn.svg(),
        ),

@mlab817
Copy link

mlab817 commented Jun 11, 2024

Actually, it would be better to pass in a Widget instead of IconData or AssetImage so it can support other widgets to be used as button.

@deven98 deven98 self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants