-
Notifications
You must be signed in to change notification settings - Fork 21
/
Dangerfile
46 lines (38 loc) · 2.37 KB
/
Dangerfile
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
pr_body = github.pr_body
pr_labels = github.pr_labels
if pr_body.include?("#skip_danger")
message("Skipping Danger due to skip_danger tag")
return
end
# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
has_wip_labels = pr_labels.any? { |label| label =~ /(WIP|Help Wanted)/ }
if github.pr_json.draft || has_wip_labels
message("Skipping Danger since the Pull Request is classed as `Draft`/`Work In Progress`")
return
end
# Don't forget to tick the required checkboxes in a PR description
missed_checkboxes = pr_body.each_line.any? { |line| line.include?("[ ]") && line.include?("(required)") }
warn("Please be sure to complete the `Contributor Checklist` in the Pull Request description") if missed_checkboxes
# Warn when there is a big PR.
warn("Big PR") if git.lines_of_code > 500
# Mainly to encourage writing up some reasoning about the PR, rather than just leaving a title.
warn("Please provide a summary in the Pull Request description") if pr_body.length < 3 && git.lines_of_code > 50
# Add a CHANGELOG entry for app changes
# has_changelog_escape_labels = pr_labels.any? { |label| label =~ /(Meta|Demo App)/ }
# has_changelog_escape_tags = pr_body =~ /(#no_changelog|#skip_changelog)/
# has_app_changes = !git.modified_files.grep(/Sources/).empty?
# has_changelog_changes = !git.modified_files.include?("CHANGELOG.md")
# if !has_changelog_escape_labels && !has_changelog_escape_tags && has_changelog_changes && has_app_changes
# message("There seems to be app changes but CHANGELOG wasn't modified." \
# "\nPlease include an entry if the PR includes user-facing changes." \
# "\nYou can find it at [CHANGELOG.md](https://github.com/GetStream/stream-video-swift/blob/main/CHANGELOG.md).")
# end
# Make it clear that a PR is ready for QA and needs to be picked up by someone to test the changes
has_ticked_qa_checkbox = pr_body.include?("[x] This PR should be manually QAed")
has_ready_for_qa_label = pr_labels.any? { |label| label.include?("Ready For QA") }
has_qaed_label = pr_labels.any? { |label| label.include?("QAed") }
if !has_qaed_label && (has_ready_for_qa_label || has_ticked_qa_checkbox)
warn("The changes should be manually QAed before the Pull Request will be merged")
end
# Check all commits have correct format. Disable the length rule, since it's hardcoded to 50 and GitHub has the limit 80
commit_lint.check(disable: [:subject_length])