Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]Reconnection(Do not merge) #503

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

[Feature]Reconnection(Do not merge) #503

wants to merge 23 commits into from

Conversation

ipavlidakis
Copy link
Collaborator

@ipavlidakis ipavlidakis commented Sep 3, 2024 •
edited
Loading

🔗 Issue Links

Open Tickets

Remaining tasks

  • Re-enable visibilityModifier
  • Centralise request timeout on WebRTCCoordinator + Stages
  • Add tests
  • Add/update documentation
  • Remove observeForceReconnectionRequests observation
  • Rewrite APIs that are using the ObjC API e.g. withUnsafePointer(to: &AssociatedKeys.delegatePublisher)
  • Try to find a way to centralise logging description for SFU events
  • Rethink the need for CallAuthenticator
  • Make DemoApp pointing to Pronto for Debug builds
  • Rename Stream_Video_Sfu_Signal_SignalServer instances to signalService
  • Confirm changeTrackSize is working as expected
  • Re-enable XCTSkipped tests
  • Reduce SDK size

Disabled tests

  • CallController_Tests
  • SFUMiddleware_Tests
  • SFUMiddlewareTests
  • ReconnectionTests.testReconnectingMessage

Skipped tests

  • CallCRUDTests.test_joinBackstageRegularUser

Known Issues

  • Tracks may disappear during the call

Test Suite

🎯 Goal

Describe why we are making this change.

📝 Summary

Provide bullet points with the most important changes in the codebase.

🛠 Implementation

Provide a detailed description of the implementation and explain your decisions if you find them relevant.

🎨 Showcase

Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.

Before After
img img

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Sep 3, 2024
@ipavlidakis ipavlidakis self-assigned this Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

1 Message
📖 Skipping Danger since the Pull Request is classed as Draft/Work In Progress

Generated by 🚫 Danger

@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch 3 times, most recently from 1e4964d to 6224a22 Compare September 4, 2024 15:10
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Sep 4, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.4 MB 7.87 MB +474 KB 🟡
StreamVideoSwiftUI 2.18 MB 2.18 MB -4 KB 🚀
StreamVideoUIKit 2.32 MB 2.31 MB -4 KB 🚀
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the feature/reconnection-v2 branch 2 times, most recently from 210e99b to feda9bc Compare September 6, 2024 08:58
@ipavlidakis ipavlidakis added this to the Reconnection v2 milestone Sep 6, 2024
@ipavlidakis
Feature/reconnection v2 attempt 1 (#480)
68c83dc
@ipavlidakis
[Fix]Failing tests (#509)
5eb4576
@ipavlidakis
[Fix]Ringing call screen closing immediately (#511)
3899aef
@ipavlidakis
[Fix]Restore active VideoFilter after reconnection (#512)
ef2bf65
@ipavlidakis
Add comments and test for SFU components (#510)
e96e767
@ipavlidakis
Fix peerConnection having the same type
d7477db
@ipavlidakis
[Fix]Missing tracks (#507)
0eb4763
@ipavlidakis
Peerconnection tests and docs (#516)
9c908cd
@ipavlidakis
[Fix]Disconnect rather than leaving call on connection lost (#517)
d935e96
@ipavlidakis
[Fix]Retain camera position after reconnection (#520)
533372c
@ipavlidakis
[Fix]Reconnection when socket disconnects before connection is lost (#…
9974502 
…519)
@ipavlidakis
Add tests for WebRTCStateMachine stages (#522)
99a6d3f
@ipavlidakis
Add docs and tests for the WebRTC components (#523)
1b9ffaa
@ipavlidakis
Update tests for RTCPeerConnectionCoordinator on handling negotiation…
e5d9c1a 
…/subscriberOffer (#526)
@ipavlidakis
[Fix]Pass all available parameters to connect (#528)
1412868
@ipavlidakis
[Fix]Migration failing due to migrationCompleted event not received (#…
385aca3 
…527)
@ipavlidakis
Point app to Pronto
0d6a4ab
@ipavlidakis
Reenable Callcontroller tests (#529)
c094422
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
109 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Reconnection v2
Development

Successfully merging this pull request may close these issues.
2 participants
@ipavlidakis @Stream-SDK-Bot