-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offscreen image audit incorrectly reporting lazy-loaded images #6677
Comments
I'd like to confirm the problem. The report ran for https://alpha.floralle.com.ua/: Defer offscreen images lists a group of images. However when the same page is inspected using Chrome Dev Tools: The only images that are loaded, are: The solution uses Intersection Observer and would not show any images until they emerge on the screen. |
Seeing the same Lighthouse issue on our site, and Pagespeed Insights won't recognize the lazy load as well, since it uses the same library. Definitely concerning since our Google AdWords rep is under the impression that Pagespeed Insights is now a weighted factor in search ranking! Hoping this can be fixed in Lighthouse as well as PI soon... |
I can confirm this as well. I've tried different solutions, both with and without |
I think I am seeing something similar. For instance, on this page on our giftshop website there are 3 images in large format and 3 in small format and at least from what I can see in the code they are using a lazy loading plugin but Lighthouse says to defer them. |
currently still seeing it on a site im working on |
Currently seeing this happening as well. Maybe my lazyloading scripts are loading/triggered before the |
I've stumbled across this issue too, and hoping for a solution. |
Getting this on a WordPress site that uses WP Rocket plugin for lazy load. I can see that lazy load is working by looking in the Chrome Network tab, but Audit says no. |
We're experiencing this as well. |
We are also having the same issue. I hope a fix will happen soon |
Yep - same here - still. Since this problem has been around for a year, I'm wondering if we'll just have to consider it may-never-fix and another thing to explain to clients inclined to treat Lighthouse/Page Speed Insights as definitive. |
This is still the case, correct? |
This is still the case in 5.6.0 but we intend to loosen this to 3 viewports in 6.0.0 (#10471) |
I'm seeing the same issue. Lighthouse is mostly correct for me too but this issue is giving me a bad performance score even though my images clearly are lazy-loaded. I wonder when this will be resolved. |
We're working on it. #10643 |
That is great news this issue is being worked on! Do you have any idea yet as to when a fix might be released? |
Still seeing this issue on our site. An off-screen image is being reported, but only one of them, even though they're all deferred. Has the #10643 PR been deployed so PSI is now using the updated checks or is it still in progress? |
@rshackleton no it has not. Should happen later this month. |
@patrickhulce thanks for confirming, it will help us set expectations for clients on our side. |
Any good current examples of unrecognized lazy loading to see in action? |
@panablue - 2 images continue to be flagged on https://songbox.rocks despite them being appropriately setup for lazy loading. |
Thank you @Gigamick. As established, PSI and the browser seem to disagree on the viewport threshold. What's the relationship of this issue with I haven't found this issue on well optimized and high-scoring pages, so I wonder if there's a correlation there. Could it only be triggered when there are appreciable other opportunities for optimization? |
@patrickhulce Has the #10643 PR been deployed so PSI is now using the updated checks or is it still in progress? Thanks in advance. |
v6 with this fix is being officially released imminently. Keep your eye out for posts about the PSI deployment timeline :) |
@patrickhulce Do you know how imminently? We're still getting false positives on this. Thanks for your help. |
It was released minutes after my comment. PSI timeline is mentioned in the post https://web.dev/lighthouse-whats-new-6.0/
|
Thanks @patrickhulce, sorry I didn't know where to check the depoyment timeline. In that case:
<img class="_desktop-visible _no-padding" loading="lazy" src="//static2.viovet.co.uk/opt/s=kr,width=340,height=320/banners/1587565188-4463.png.webp" srcset="//static2.viovet.co.uk/opt/s=kr,width=340,height=320/banners/1587565188-4463.png.webp 1x, //static2.viovet.co.uk/opt/s=kr,width=680,height=640/banners/1587565188-4463.png.webp 2x " alt="SL 25% off VioPet Food 2kg"> Thanks for your help. |
PSI has not been updated yet.
It's still May 26. If it's still happening June 1 feel free to bug the PSI team ;) |
Sorry for the misunderstanding. Thanks 👍 |
This is broken again, please re-open. |
Please file a new bug report with repro steps and environment information then @johncarlson21. We have no idea if you're using the version of Lighthouse in which this should be fixed or if it's even the same root cause when that's all you say. |
Provide the steps to reproduce
What is the current behavior?
https://oldnavy.gap.com/ lazy-loads below-the-fold ("BTF") images (example BTF image that is lazy-loaded on homepage).
The following LH reports incorrectly show lazy-loaded images in "defer offscreen images" audit. In addition, the above-the-fold images do not appear to render in timeline:
However, when run in CDT (v.3.0.3) and via WebpageTest (v.4.0.0-alpha.2-3.2.1), this audit passes and ATF images render.
The same audit discrepancy exists for https://pwa.www.1800flowers.com/ when run from web.dev vs. WPT.
I did notice that a change was made to offscreen images audit in v4.0.0-alpha.1.
What is the expected behavior?
Offscreen images audit should pass as BTF images are lazy-loaded.
The text was updated successfully, but these errors were encountered: