Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme with vendoring details #168

Open
Sheshagiri opened this issue Apr 2, 2019 · 0 comments
Open

update readme with vendoring details #168

Sheshagiri opened this issue Apr 2, 2019 · 0 comments

Comments

@Sheshagiri
Copy link

Not a bug as such, it would be nice to add a note to the readme on how to get the go app that is vendored built using a multistage Dockerfile.

The current readme

WORKDIR /go/src/app
COPY main.go .

RUN /usr/local/go/bin/go build -o app .

doesn't seem to work as /go/src/app is not it gopath. Happy to submit a pr with updated readme.

WORKDIR /root/go/src/app
COPY . .

RUN /usr/local/go/bin/go build -o app .

setting the workdir to /root/go/src/app did the magic for me :-) . I guess updating the WORKDIR to /root/go/src/app works for everyone including apps coming with vendor dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant