-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A name colission with soymuchacho/libshared
#69
Comments
Probably doesn't make sense to use a DSO that isn't linked statically. Taskwarrior/timewarrior have specific versions of libshared that they peg to (ie using git submodules) and the projects operate with different release schedules. In any case, libshared is probably only useful to the TW projects, and not a general purpose library, so a name collision isn't really problematic. |
Fair enough. |
You don't need to build libshared yourself, the build system does it, so it's not any more effort is it? Do you mean because you have to init the submodules? |
Initting modules might be a reason too, although a weaker one. |
I see where you're coming from, unfortunately, it's not exactly the same compilation work, because both In case they are poining to the same commit in the submodule, you could circumvent the double build requirement by symlinking libshared from one repository into another 🤔 |
Ah, thanks for the tip! I guess I am fine with that then. Still no plans to change the library name to something more specific?=) |
is it used somewhere outside the context of the GothenburgBitFactory programs' linktime namespaces, such that it's even possible to collide with anything? |
I thought about making this project a standalone lib.
This happened after I saw both Task Warrior and Timewarrior use the same library and that I am building it twice.
And googled this name and I found another project of the same name (born at the similar time, Jul 16, 2016):
https://github.com/soymuchacho/libshared
Would it be acceptable for this project to adjust the name? Just a thought.
The text was updated successfully, but these errors were encountered: