Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data::concentration::simd: Correctly error out when grid size isn't right. #6

Open
HadrienG2 opened this issue Jul 7, 2023 · 1 comment
Open

data::concentration::simd: Correctly error out when grid size isn't right. #6

HadrienG2 opened this issue Jul 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@HadrienG2
Copy link
Owner

The assertion in SIMDConcentration::simd_shape() dates back from a time where compute backends did not have a proper error reporting system. Now we can do better.
@HadrienG2
Copy link
Owner Author

Generally speaking, use of panics (assert, expect, unwrap, unreachable, ...) should be audited and reduced.

@HadrienG2 HadrienG2 added the bug Something isn't working label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HadrienG2